Skip to content

zNPCSpawner: Best Match Attempt Function Implementations#536

Merged
JoshSanch merged 5 commits intobfbbdecomp:mainfrom
JoshSanch:zNPCSpawner
May 10, 2025
Merged

zNPCSpawner: Best Match Attempt Function Implementations#536
JoshSanch merged 5 commits intobfbbdecomp:mainfrom
JoshSanch:zNPCSpawner

Conversation

@JoshSanch
Copy link
Collaborator

A few weird ones here but the bones should be good for future contributors to focus on fixing the weirdness and not have to decomp the whole function.

@github-actions
Copy link

🆗 ✅

+2791 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 19

📈 main/SB/Game/zNPCSpawner - .text +2106 bytes -> 79.92%
📈 main/SB/Game/zNPCSpawner - .text +504 bytes -> 91.30%
📈 main/SB/Game/zNPCSpawner - .rodata +120 bytes -> 62.86%
main/SB/Game/zNPCSpawner - .data +48 bytes -> 100.00%
📈 main/SB/Game/zNPCSpawner - .sdata2 +5 bytes -> 76.47%
main/SB/Game/zNPCSpawner - .sbss +8 bytes -> 100.00%
📈 main/SB/Game/zNPCSpawner - zNPCSpawner::IsNearbyMover(xBound*, int, xCollis*) +196 bytes -> 47.57%
📈 main/SB/Game/zNPCSpawner - zNPCSpawner::IsSPLZClear(zMovePoint*) +300 bytes -> 74.26%
📈 main/SB/Game/zNPCSpawner - zNPCSpawner::SelectSP(const SMNPCStatus*) +290 bytes -> 73.27%
main/SB/Game/zNPCSpawner - zNPCSpawner::Notify(en_SM_NOTICES, void*) +320 bytes -> 100.00%
📈 main/SB/Game/zNPCSpawner - zNPCSpawner::StatForSP(zMovePoint*, int) +116 bytes -> 39.73%
📈 main/SB/Game/zNPCSpawner - xUtil_select<SMSPStatus>(SMSPStatus**, int, const float*) +252 bytes -> 91.30%
📈 main/SB/Game/zNPCSpawner - xUtil_select<SMNPCStatus>(SMNPCStatus**, int, const float*) +252 bytes -> 91.30%
📈 main/SB/Game/zNPCSpawner - zNPCSpawner::SpawnBeastie(SMNPCStatus*, SMSPStatus*) +192 bytes -> 71.64%
main/SB/Game/zNPCSpawner - zNPCSpawner::ChildCleanup(float) +268 bytes -> 100.00%
📈 main/SB/Game/zNPCSpawner - zNPCSpawner::Owned(zNPCCommon*) const +164 bytes -> 74.55%
main/SB/Game/zNPCSpawner - zNPCSpawner::ClearActive() +92 bytes -> 100.00%
main/SB/Game/zNPCSpawner - zNPCSpawner::Receivable(en_SM_NOTICES, void*) const +84 bytes -> 100.00%
main/SB/Game/zNPCSpawner - zNPCSpawner::ClearPending() +84 bytes -> 100.00%

@JoshSanch JoshSanch merged commit 7445eac into bfbbdecomp:main May 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant